Skip to content

Use pytest everywhere#29

Merged
joanise merged 3 commits into
mainfrom
dev.ej/full-pytest
May 1, 2026
Merged

Use pytest everywhere#29
joanise merged 3 commits into
mainfrom
dev.ej/full-pytest

Conversation

@joanise

@joanise joanise commented Apr 29, 2026

Copy link
Copy Markdown
Member

@semanticdiff-com

semanticdiff-com Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  aligner/tests/test_cli.py  25% smaller
  .coveragerc Unsupported file format
  .github/workflows/test.yml  0% smaller
  .gitignore Unsupported file format
  pyproject.toml Unsupported file format

@joanise joanise requested a review from roedoejet April 29, 2026 18:23
@joanise joanise mentioned this pull request Apr 29, 2026
Merged
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown 
CLI load time: 0:00.16
Pull Request HEAD: 98741ea470ad5675badc62a22361baf53433948b
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

@codecov

codecov Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.72%. Comparing base (170bb74) to head (98741ea).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   96.86%   93.72%   -3.14%     
==========================================
  Files           5        5              
  Lines         223      223              
  Branches        0       40      +40     
==========================================
- Hits          216      209       -7     
  Misses          7        7              
- Partials        0        7       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise

joanise commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

Coverage went down because I enabled branch coverage. If you count Hits+Partials how, you get what we had for Hits before.

roedoejet
roedoejet approved these changes May 1, 2026
View reviewed changes

@roedoejet roedoejet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joanise joanise merged commit 98741ea into main May 1, 2026
6 of 7 checks passed
@joanise joanise deleted the dev.ej/full-pytest branch May 1, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roedoejet roedoejet roedoejet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joanise @roedoejet